aokolnychyi commented on code in PR #9611:
URL: https://github.com/apache/iceberg/pull/9611#discussion_r1484745294


##########
core/src/main/java/org/apache/iceberg/actions/BaseCommitService.java:
##########
@@ -227,13 +228,18 @@ private void commitReadyCommitGroups() {
       try {
         commitOrClean(batch);
         committedRewrites.addAll(batch);
+        succeededCommits++;
       } catch (Exception e) {
         LOG.error("Failure during rewrite commit process, partial progress 
enabled. Ignoring", e);
       }
       inProgressCommits.remove(inProgressCommitToken);
     }
   }
 
+  public int getSucceededCommits() {

Review Comment:
   Minor: No `get` prefixes in getters to match the style of the project.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to