nastra commented on code in PR #9711:
URL: https://github.com/apache/iceberg/pull/9711#discussion_r1485810348
##########
mr/src/test/java/org/apache/iceberg/mr/hive/TestTables.java:
##########
@@ -417,18 +418,17 @@ static class CustomCatalogTestTables extends TestTables {
private final String warehouseLocation;
- CustomCatalogTestTables(Configuration conf, TemporaryFolder temp, String
catalogName)
- throws IOException {
+ CustomCatalogTestTables(Configuration conf, Path temp, String catalogName)
throws IOException {
this(
conf,
temp,
(HiveVersion.min(HiveVersion.HIVE_3) ? "file:" : "")
- + temp.newFolder("custom", "warehouse").toString(),
+ + temp.resolve(Paths.get("custom", "warehouse")),
Review Comment:
we should also use `Files.createTempDirectory(temp, ...)` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
