rahil-c commented on code in PR #9717:
URL: https://github.com/apache/iceberg/pull/9717#discussion_r1487236228
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3324,6 +3348,97 @@ components:
type: integer
format: int64
+ TypeValue:
+ oneOf:
+ - $ref: '#/components/schemas/PrimitiveTypeValue'
+ - $ref: '#/components/schemas/MapTypeValue'
+ - $ref: '#/components/schemas/StructTypeValue'
+
+ MapTypeValue:
+ type: object
+ properties:
+ keys:
+ type: array
+ items:
+ $ref: '#/components/schemas/TypeValue'
+ values:
+ type: array
+ items:
+ $ref: '#/components/schemas/TypeValue'
+
+ StructTypeValue:
+ type: object
+ additionalProperties:
+ oneOf:
+ - $ref: '#/components/schemas/TypeValue'
+
+ PrimitiveTypeValue:
+ oneOf:
+ - type: boolean
+ - type: integer
+ - type: integer
+ format: int64
+ - type: number
+ - type: string
+ - type: string
+ format: byte
+ - type: array
+ items:
+ $ref: '#/components/schemas/TypeValue'
+
+ ContentFile:
+ type: object
+ required:
+ - spec-id
+ - content
+ - file-path
+ - file-format
+ - file-size-in-bytes
+ - record-count
+ properties:
+ spec-id:
+ type: integer
+ content:
Review Comment:
I think we can model like this
https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/FileContent.java#L27
```
content:
$ref: '#/components/schemas/FileContent'
FileContent:
type: string
enum:
- data
- position-deletes
- equality-deletes
```
similar to whats in proposal
https://docs.google.com/document/d/1FdjCnFZM1fNtgyb9-v9fU4FwOX4An-pqEwSaJe8RgUg/edit
cc @jackye1995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
