manuzhang commented on code in PR #9724: URL: https://github.com/apache/iceberg/pull/9724#discussion_r1492660971
########## api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java: ########## @@ -99,6 +99,20 @@ public interface RewriteDataFiles boolean USE_STARTING_SEQUENCE_NUMBER_DEFAULT = true; + /** + * Removes dangling delete files from current snapshot after compaction. A delete file is + * considered dangling if it does not apply to any non-expired data file. Review Comment: > A delete file is considered dangling if it does not apply to any non-expired data file. I think the most accurate wording is `if it does not apply to data files of current snapshot`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
