rdblue commented on code in PR #9732:
URL: https://github.com/apache/iceberg/pull/9732#discussion_r1492829614
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1246,7 +1246,6 @@ public Builder setRef(String name, SnapshotRef ref) {
public Builder removeRef(String name) {
if (SnapshotRef.MAIN_BRANCH.equals(name)) {
this.currentSnapshotId = -1;
- snapshotLog.clear();
Review Comment:
I think I agree with @amogh-jahagirdar here. It's better to do that in
`buildReplacement` because `removeRef` could be used in other cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
