rdblue commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1496224382
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -140,6 +139,7 @@ public void initialize(String name, Map<String, String>
properties) {
if (initializeCatalogTables) {
initializeCatalogTables();
}
+ checkAndMaybeUpdateSchema();
Review Comment:
I think the error handling is incorrect here. The errors state that the
schema could not be initialized, but that applies only to
`initializeCatalogTables`. I think the try/catch should move into the
`initializeCatalogTables` method and `updateSchemaIfRequired` should have its
own error handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
