rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1496301006
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2800,6 +3053,59 @@ components:
additionalProperties:
type: string
+ PlanContext:
+ type: object
+ required:
+ - select
+ - options
+ properties:
+ select:
+ description: A list of the selected columns
+ type: array
+ items:
+ type: string
+ project:
Review Comment:
@rdblue Hey Ryan thanks for the very detailed review and suggestions, I just
have a couple of questions for my own understanding.
For 2. by unbounded filter expression do you mean the following:
> a filter expression that does not specify a value for the field being
filtered. For example:
WHERE dataset.field
This filter expression checks for the presence of the field, but does not
check for a specific value. It will include all items that have a value for the
specified field, regardless of what the actual value is.
If so, are clients then not providing a filter value to the service such as
`where id=5`? Would this cause a large amount of data for the service to send
back over the network? Wouldn't it be better to leverage the service for
filtering on a specified value so the client has less work to do?
For 4. My understanding is that keeping `options` as optional would be
useful for clients to send additional information to the service for planning.
cc @jackye1995 for his thoughts as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
