nastra commented on code in PR #9765:
URL: https://github.com/apache/iceberg/pull/9765#discussion_r1497144363
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -150,6 +150,20 @@ public void initialize(String name, Map<String, String>
properties) {
Thread.currentThread().interrupt();
throw new UncheckedInterruptedException(e, "Interrupted in call to
initialize");
}
+
+ try {
+ updateSchemaIfRequired();
Review Comment:
Ryan mentioned in
https://github.com/apache/iceberg/pull/9765#discussion_r1496224382 that the
error handling should move inside `updateSchemaIfRequired()` and we should
probably do the same for `initializeCatalogTables()`. Otherwise the
`initialize()` method gets quite bloated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
