Fokko commented on code in PR #245:
URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1498337498
##########
pyiceberg/table/metadata.py:
##########
@@ -308,7 +308,8 @@ def construct_partition_specs(cls, data: Dict[str, Any]) ->
Dict[str, Any]:
data[PARTITION_SPECS] = [{"field-id": 0, "fields": ()}]
data[LAST_PARTITION_ID] = max(
- [field.get(FIELD_ID) for spec in data[PARTITION_SPECS] for field
in spec[FIELDS]], default=PARTITION_FIELD_ID_START
+ [field.get(FIELD_ID) for spec in data[PARTITION_SPECS] for field
in spec[FIELDS]],
+ default=PARTITION_FIELD_ID_START - 1,
Review Comment:
Ah, I see. So the next one will be 1000. It feels a bit like a workaround,
let me check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
