nastra commented on code in PR #9760: URL: https://github.com/apache/iceberg/pull/9760#discussion_r1500691064
########## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRemoveOrphanFilesProcedure.java: ########## @@ -18,8 +18,10 @@ */ package org.apache.iceberg.spark.extensions; +import static java.nio.file.Files.createTempDirectory; Review Comment: we typically only statically import stuff from AssertJ (and a few other things) but avoid statically importing stuff like these methods, so please use `Files.createTempDirectory` to be in-line with the rest of the codebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
