nastra commented on code in PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#discussion_r1502439184


##########
data/src/test/java/org/apache/iceberg/data/DataTestHelpers.java:
##########
@@ -43,7 +42,7 @@ public static void assertEquals(Types.StructType struct, 
Record expected, Record
   public static void assertEquals(Types.ListType list, List<?> expected, 
List<?> actual) {
     Type elementType = list.elementType();
 
-    Assert.assertEquals("List size should match", expected.size(), 
actual.size());
+    org.junit.jupiter.api.Assertions.assertEquals(expected.size(), 
actual.size(), "List size should match");

Review Comment:
   please use AssertJ assertions. See also 
https://iceberg.apache.org/contribute/#assertj



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to