zeroshade commented on code in PR #59:
URL: https://github.com/apache/iceberg-go/pull/59#discussion_r1503479405
##########
table/metadata.go:
##########
@@ -399,3 +400,32 @@ func (m *MetadataV2) UnmarshalJSON(b []byte) error {
m.preValidate()
return m.validate()
}
+
+func NewMetadataV2(schema *iceberg.Schema, partitionSpec
iceberg.PartitionSpec, sortOrder SortOrder, location string, tableUUID
uuid.UUID, properties iceberg.Properties) (*MetadataV2, error) {
Review Comment:
Should we use a builder pattern like we do for manifests? Instead of a
single func with a ton of params?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
