Fokko commented on code in PR #471:
URL: https://github.com/apache/iceberg-python/pull/471#discussion_r1503988774
##########
pyiceberg/table/__init__.py:
##########
@@ -1512,8 +1432,33 @@ class Move:
other_field_id: Optional[int] = None
-class UpdateSchema:
- _table: Optional[Table]
+U = TypeVar('U')
+
+
+class TableMetadataUpdate(ABC, Generic[U]):
+ _transaction: Transaction
+ _table_metadata: TableMetadata
+
+ def __init__(self, transaction: Transaction, table_metadata:
TableMetadata) -> None:
+ self._transaction = transaction
+ self._table_metadata = table_metadata
Review Comment:
I think this was still in there from when you could do an update directly on
a table itself. I've removed it and it is much cleaner now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
