liurenjie1024 commented on code in PR #169:
URL: https://github.com/apache/iceberg-rust/pull/169#discussion_r1505434226
##########
crates/iceberg/src/expr/term.rs:
##########
@@ -17,21 +17,91 @@
//! Term definition.
-use crate::spec::NestedFieldRef;
+use crate::expr::{BinaryExpression, Predicate, PredicateOperator};
+use crate::spec::{Datum, NestedField, NestedFieldRef};
+use std::fmt::{Display, Formatter};
/// Unbound term before binding to a schema.
-pub type UnboundTerm = UnboundReference;
+pub type Term = Reference;
/// A named reference in an unbound expression.
/// For example, `a` in `a > 10`.
-pub struct UnboundReference {
+#[derive(Debug, Clone)]
+pub struct Reference {
name: String,
}
+impl Reference {
+ /// Create a new unbound reference.
+ pub fn new(name: impl ToString) -> Self {
Review Comment:
Good point!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
