ZENOTME commented on code in PR #207:
URL: https://github.com/apache/iceberg-rust/pull/207#discussion_r1506074443
##########
crates/iceberg/src/scan.rs:
##########
@@ -180,7 +185,42 @@ pub type ArrowRecordBatchStream = BoxStream<'static,
crate::Result<RecordBatch>>
impl FileScanTask {
/// Returns a stream of arrow record batches.
pub async fn execute(&self) -> crate::Result<ArrowRecordBatchStream> {
- todo!()
+ match self.data_file.content_type() {
Review Comment:
And seems it should not contain `FileIO` in FileScanTask if we want it can
be de/serde. Maybe we can get a stream of FileScanTask and use FileIO and
FileScanTask to construct the reader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
