rdblue commented on a change in pull request #1124:
URL: https://github.com/apache/iceberg/pull/1124#discussion_r447173585



##########
File path: 
spark/src/test/java/org/apache/iceberg/spark/source/TestDataFrameWrites.java
##########
@@ -233,17 +234,14 @@ private void writeData(Iterable<Record> records, Schema 
schema, String location)
 
   @Test
   public void testNullableWithWriteOption() throws IOException {
+    Assume.assumeTrue("Spark 3.0 rejects writing nulls to a required column", 
spark.version().startsWith("2"));

Review comment:
       We can support it for `DataFrame` operations by returning a table schema 
with all optional columns when loading the table. But since that's more work to 
produce an all-optional schema, I think it should be done in a follow-up.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to