BsoBird commented on code in PR #9546:
URL: https://github.com/apache/iceberg/pull/9546#discussion_r1505224636
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##########
@@ -368,58 +431,63 @@ private void renameToFinal(FileSystem fs, Path src, Path
dst, int nextVersion) {
if (fs.exists(dst)) {
throw new CommitFailedException("Version %d already exists: %s",
nextVersion, dst);
}
-
- if (!fs.rename(src, dst)) {
- CommitFailedException cfe =
- new CommitFailedException("Failed to commit changes using rename:
%s", dst);
- RuntimeException re = tryDelete(src);
- if (re != null) {
- cfe.addSuppressed(re);
- }
- throw cfe;
- }
- } catch (IOException e) {
- CommitFailedException cfe =
- new CommitFailedException(e, "Failed to commit changes using rename:
%s", dst);
- RuntimeException re = tryDelete(src);
- if (re != null) {
- cfe.addSuppressed(re);
+ if (!nextVersionIsLatest(nextVersion, fs)) {
Review Comment:
This is because it is possible that an older version of the versionHint is
stored in the versionHint, and the metaDataFile corresponding to this older
version has been cleaned up. If we don't check for it, then we can successfully
commit an old version, which seems unreasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
