jrouly commented on code in PR #490:
URL: https://github.com/apache/iceberg-python/pull/490#discussion_r1509829128
##########
pyiceberg/catalog/glue.py:
##########
@@ -252,6 +259,22 @@ def _construct_database_input(database_name: str,
properties: Properties) -> Dat
return database_input
+def _register_glue_catalog_id_with_glue_client(glue: GlueClient,
glue_catalog_id: str) -> None:
+ """
+ Register the Glue Catalog ID (AWS Account ID) as a parameter on all Glue
client methods.
+
+ It's more ergonomic to do this than to pass the CatalogId as a parameter
to every client call since it's an optional
+ parameter and boto3 does not support 'None' values for missing parameters.
Review Comment:
Another alternative would be to wrap `GlueClient` in a thin wrapper class
that bakes in Glue Catalog ID and exposes just the functionality required by
the caller in `GlueCatalog`. But that felt like even more work and places to
forget to include `CatalogId` when adding new functions to the client wrapper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
