viirya commented on code in PR #226: URL: https://github.com/apache/iceberg-rust/pull/226#discussion_r1510017188
########## crates/iceberg/src/spec/datatypes.rs: ########## @@ -171,13 +171,13 @@ pub enum PrimitiveType { Int, /// 64-bit signed integer Long, - /// 32-bit IEEE 754 floating bit. + /// 32-bit IEEE 754 floating point. Float, - /// 64-bit IEEE 754 floating bit. + /// 64-bit IEEE 754 floating point. Review Comment: Based on the doc: https://iceberg.apache.org/spec/#primitive-types -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org