nastra commented on code in PR #9890:
URL: https://github.com/apache/iceberg/pull/9890#discussion_r1516290533
##########
nessie/src/test/java/org/apache/iceberg/nessie/TestNessieCatalog.java:
##########
@@ -169,4 +171,25 @@ public void testWarehouseLocationWithTrailingSlash() {
+ "/"
+ TABLE.name());
}
+
+ @Override
+ @Test
+ public void listTablesInEmptyNamespace() {
+ Namespace ns = Namespace.of("ns");
+
+ if (requiresNamespaceCreate()) {
+ catalog().createNamespace(ns);
+ }
+
+ TableIdentifier table1 = TableIdentifier.of(Namespace.empty(), "table_1");
+ TableIdentifier table2 = TableIdentifier.of(ns, "table_2");
+
+ catalog().buildTable(table1, SCHEMA).create();
+ catalog().buildTable(table2, SCHEMA).create();
+
+ // TODO this lists all available tables and deviates from the behavior in
other catalogs and
+ // should probably be fixed
+ Assertions.assertThat(catalog().listTables(Namespace.empty()))
Review Comment:
But nessie supports creating a table/view withing the empty namespace, which
is a valid use case. If creating a table/view in an empty namespace is
supported, then listing should be supported as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
