rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1517071309
##########
open-api/rest-catalog-open-api.py:
##########
@@ -905,6 +973,28 @@ class CreateTableRequest(BaseModel):
properties: Optional[Dict[str, str]] = None
+class PlanContext(BaseModel):
+ select: List[str] = Field(..., description='A list of the selected
columns')
+ project: Optional[List[str]] = Field(None, description='A list of the
projections')
+ filter: Optional[Expression] = None
+ options: Dict[str, str]
+ snapshot_id: Optional[int] = Field(None, alias='snapshot-id')
+ from_snapshot_id: Optional[int] = Field(None, alias='from-snapshot-id')
Review Comment:
I think @rdblue suggestion is to use a json list called `snapshot-range`,
instead of `fromSnapshot` and `toSnapshot`. From the description he suggested
start as `exclusive` and end as `inclusive`
> snapshot-range: a JSON list containing exactly 2 int64 snapshot IDs (if
snapshot-id is not present) representing the start (exclusive) and end
(inclusive) snapshots.
However @stevenzwu I think i see your point since the Java api for
incremental scan has both inclusive and exclusive
https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/IncrementalScan.java#L34
```
ThisT fromSnapshotExclusive(long fromSnapshotId);
ThisT fromSnapshotInclusive(long fromSnapshotId);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
