himadripal commented on code in PR #9839:
URL: https://github.com/apache/iceberg/pull/9839#discussion_r1517402474
##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java:
##########
@@ -471,7 +515,13 @@ static void setTokenRefreshNumRetries(int retries) {
*/
public static AuthSession empty() {
return new AuthSession(
- ImmutableMap.of(), null, null, null, OAuth2Properties.CATALOG_SCOPE,
null);
+ ImmutableMap.of(),
+ null,
+ null,
+ null,
+ OAuth2Properties.CATALOG_SCOPE,
+ null,
+ ImmutableMap.of());
Review Comment:
+1 to the painful to add parameters. With this PR, I have tried to add all
optional oauth parameters (including scope) in a map but having a class like
`[AuthConfig](https://github.com/apache/iceberg/commit/3bed59907f4230d10a97742c58ab4b85ce7b1ebf#diff-d783470ff004c360395125d467f1aadd776c8c9e925ba52639a405a03a72b870R647),`
which holds all params with validation logic and passing it around would be
best.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
