rdblue commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1520455028
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2068,6 +2162,145 @@ components:
items:
$ref: '#/components/schemas/PartitionStatisticsFile'
+ PlanTask:
+ description:
+ A JSON object that contains information provided by the server,
+ to be utilized by clients for distributed planning, should be supplied
+ as is for input in PlanTable operation.
+ type: object
+
+ FileScanTask:
+ type: object
+ required:
+ - schema
+ - spec
+ - start
+ - length
+ - data-file
+ properties:
+ data-file:
+ $ref: '#/components/schemas/ContentFile'
+ partition:
+ type: object
+ additionalProperties:
+ type: string
+ size-bytes:
+ type: number
+ start:
+ type: number
+ length:
+ type: number
+ estimated-rows-count:
+ type: number
+ delete-files:
+ type: array
+ items:
+ $ref: '#/components/schemas/ContentFile'
+ schema:
+ $ref: '#/components/schemas/Schema'
+ spec:
+ $ref: '#/components/schemas/PartitionSpec'
+ residual-filter:
+ $ref: '#/components/schemas/Expression'
+
+ TypeValue:
+ oneOf:
+ - $ref: '#/components/schemas/PrimitiveTypeValue'
+ - $ref: '#/components/schemas/MapTypeValue'
+ - $ref: '#/components/schemas/StructTypeValue'
+
+ MapTypeValue:
+ type: object
+ properties:
+ keys:
+ type: array
+ items:
+ $ref: '#/components/schemas/TypeValue'
+ values:
+ type: array
+ items:
+ $ref: '#/components/schemas/TypeValue'
+
+ StructTypeValue:
+ type: object
+ additionalProperties:
+ oneOf:
+ - $ref: '#/components/schemas/TypeValue'
+
+ PrimitiveTypeValue:
+ oneOf:
+ - type: boolean
+ - type: integer
+ - type: integer
+ format: int64
+ - type: number
+ - type: string
+ - type: string
+ format: byte
+ - type: array
+ items:
+ $ref: '#/components/schemas/TypeValue'
+
+ ContentFile:
+ type: object
+ required:
+ - spec-id
Review Comment:
I think I'd prefer making it required. I missed this in the other PR review
and I don't see why we wouldn't require it. The partition may be empty, but
it's nice to always send it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
