ggershinsky commented on code in PR #8252:
URL: https://github.com/apache/iceberg/pull/8252#discussion_r1522685844
##########
core/src/main/java/org/apache/iceberg/ManifestWriter.java:
##########
@@ -52,13 +56,14 @@ public abstract class ManifestWriter<F extends
ContentFile<F>> implements FileAp
private long deletedRows = 0L;
private Long minDataSequenceNumber = null;
- private ManifestWriter(PartitionSpec spec, OutputFile file, Long snapshotId)
{
- this.file = file;
+ private ManifestWriter(PartitionSpec spec, EncryptedOutputFile file, Long
snapshotId) {
+ this.file = file.encryptingOutputFile();
this.specId = spec.specId();
- this.writer = newAppender(spec, file);
+ this.writer = newAppender(spec, file.encryptingOutputFile());
this.snapshotId = snapshotId;
this.reused = new GenericManifestEntry<>(spec.partitionType());
this.stats = new PartitionSummary(spec);
+ this.keyMetadataBuffer = file.keyMetadata().buffer();
Review Comment:
In the writer, we pass the `EncryptionKeyMetadata.EMPTY` object for
unencrypted manifests. But to be on the safe side, we can also check for null
objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
