pvary commented on code in PR #9998:
URL: https://github.com/apache/iceberg/pull/9998#discussion_r1529924929
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopStreams.java:
##########
@@ -185,8 +185,20 @@ public void flush() throws IOException {
@Override
public void close() throws IOException {
- stream.close();
- this.closed = true;
+ try {
+ stream.close();
+ // {@link org.apache.hadoop.fs.s3a.S3ABlockOutputStream#close()} calls
{@link
+ // org.apache.hadoop.fs.s3a.S3ABlockOutputStream#putObject()}
+ // which doesn't throw an exception when interrupted. Need to handle
interrupts here to make
+ // sure file is uploaded on close.
+ if (Thread.interrupted()
+ && "S3ABlockOutputStream"
Review Comment:
Could we create a class with a same name in a different package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
