nastra commented on code in PR #10002:
URL: https://github.com/apache/iceberg/pull/10002#discussion_r1530436787
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java:
##########
@@ -66,6 +67,9 @@ class GlueTableOperations extends
BaseMetastoreTableOperations {
// same as org.apache.hadoop.hive.metastore.TableType.EXTERNAL_TABLE
// more details:
https://docs.aws.amazon.com/glue/latest/webapi/API_TableInput.html
private static final String GLUE_EXTERNAL_TABLE_TYPE = "EXTERNAL_TABLE";
+ private static final String GLUE_ICEBERG_METADATA_REFRESH_MAX_RETRIES =
+ "iceberg.glue.metadata-refresh-max-retries";
Review Comment:
I don' think we should be adding this property for Glue. If we really want
to do this, then I think we should parameterize the default max-refresh setting
in `BaseMetastoreTableOperations`.
Also having a test similar to
https://github.com/apache/iceberg/blob/09b44bb66f4b56bb093a070dec9fcedea98d67ab/hive-metastore/src/test/java/org/apache/iceberg/hive/HiveTableTest.java#L614-L625
would be good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
