a-agmon commented on code in PR #284:
URL: https://github.com/apache/iceberg-rust/pull/284#discussion_r1531518572
##########
crates/iceberg/src/spec/manifest.rs:
##########
@@ -1052,6 +1052,89 @@ pub struct DataFile {
pub(crate) sort_order_id: Option<i32>,
}
+impl DataFile {
+ /// Get the content type of the data file (data, equality deletes, or
position deletes)
+ pub fn content(&self) -> DataContentType {
Review Comment:
Thanks @liurenjie1024 , You mean to `#[inline]` all pub methods on DataFile?
I actually thought about this, but then saw that inline was not used on
other pub struct methods (such as Table, Namespace, etc) so preferred to
maintain consistency.
If you think its better then I will do this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
