Dysprosium0626 commented on code in PR #261:
URL: https://github.com/apache/iceberg-rust/pull/261#discussion_r1533685816
##########
crates/iceberg/src/spec/schema.rs:
##########
@@ -1338,4 +1533,430 @@ table {
);
}
}
+ #[test]
+ fn test_schema_prune_columns_string() {
+ let expected_schema =
Type::Struct(StructType::new(vec![NestedField::optional(
Review Comment:
The result of visiting a schema is a `Type`(see
https://github.com/apache/iceberg/blob/c07f2aabc0a1d02f068ecf1514d2479c0fbdd3b0/api/src/main/java/org/apache/iceberg/types/PruneColumns.java#L49)
so I construct a `Type` here.
Building a schema is ok but I need to get certain field and reconstruct a
`Type` in `assert_eq`. Do we need to convert all test cases to this style?
Maybe this is a naming issue cuz `expected_schema ` is actually a type...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
