szehon-ho commented on code in PR #10020:
URL: https://github.com/apache/iceberg/pull/10020#discussion_r1535196147
##########
api/src/main/java/org/apache/iceberg/types/AssignFreshIds.java:
##########
@@ -18,19 +18,13 @@
*/
package org.apache.iceberg.types;
-import java.util.Iterator;
-import java.util.List;
-import java.util.function.Supplier;
import org.apache.iceberg.Schema;
-import org.apache.iceberg.relocated.com.google.common.collect.Lists;
-class AssignFreshIds extends TypeUtil.CustomOrderSchemaVisitor<Type> {
- private final Schema visitingSchema;
+class AssignFreshIds extends BaseAssignIds {
Review Comment:
The change here is just to refactor to a base class, for logic re-use.
While we can use this class as-is, it seems only able to completely
re-assign ids, and in our case it seems cleaner to only re-assign ids when they
collide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
