lirui-apache commented on code in PR #10016:
URL: https://github.com/apache/iceberg/pull/10016#discussion_r1536796825
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCommits.java:
##########
@@ -397,6 +399,36 @@ public void testLockExceptionUnknownSuccessCommit() throws
TException, Interrupt
.isTrue();
}
+ @Test
+ public void testChangeLockWithAlterTable() throws Exception {
+ Table table = catalog.loadTable(TABLE_IDENTIFIER);
+ HiveTableOperations ops = (HiveTableOperations) ((HasTableOperations)
table).operations();
+ TableMetadata base = ops.current();
+ final HiveLock initialLock = ops.lockObject(base);
+
+ AtomicReference<HiveLock> lockRef = new AtomicReference<>();
+ HiveTableOperations spyOps = spy(ops);
+ doAnswer(
+ i -> {
+ lockRef.set(ops.lockObject(i.getArgument(0)));
+ return lockRef.get();
+ })
+ .when(spyOps)
+ .lockObject(any());
Review Comment:
Yeah, but would you mind elaborate why `any` is bad? The stub here is meant
to capture the lock returned by `lockObject`. I don't understand why we care
about the argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
