liurenjie1024 commented on code in PR #304:
URL: https://github.com/apache/iceberg-rust/pull/304#discussion_r1539152802
##########
crates/catalog/glue/src/error.rs:
##########
@@ -15,15 +15,13 @@
// specific language governing permissions and limitations
// under the License.
-//! Iceberg Glue Catalog implementation.
-
use anyhow::anyhow;
use std::fmt::Debug;
use iceberg::{Error, ErrorKind};
/// Format AWS SDK error into iceberg error
-pub fn from_aws_error<T>(error: aws_sdk_glue::error::SdkError<T>) -> Error
+pub fn from_sdk_error<T>(error: aws_sdk_glue::error::SdkError<T>) -> Error
Review Comment:
In this case, how about we make the function crate private so that it's not
exposed to user?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
