rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1520289302
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -224,6 +229,12 @@ public void initialize(String name, Map<String, String>
unresolved) {
client, tokenRefreshExecutor(), token,
expiresAtMillis(mergedProps), catalogAuth);
}
+ String restPaginationEnabledValue =
mergedProps.get(REST_PAGINATION_ENABLED);
Review Comment:
@geruh @jackye1995 @nastra @rdblue
Thanks for taking a look, I think its fine to remove the
`REST_PAGINATION_ENABLED` flag.
Im not sure though why we have to remove the configuration `REST_PAGE_SIZE`
as how does the client (configure their engine such as spark) to set `pageSize`
correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
