rahil-c commented on code in PR #9782: URL: https://github.com/apache/iceberg/pull/9782#discussion_r1560187545
########## core/src/test/java/org/apache/iceberg/rest/responses/TestListNamespacesResponse.java: ########## @@ -34,7 +34,7 @@ public class TestListNamespacesResponse extends RequestResponseTestBase<ListName @Test public void testRoundTripSerDe() throws JsonProcessingException { - String fullJson = "{\"namespaces\":[[\"accounting\"],[\"tax\"]]}"; + String fullJson = "{\"namespaces\":[[\"accounting\"],[\"tax\"]],\"next-page-token\":null}"; Review Comment: One issue though is that since we have changed the `ListNamespaceResponse` to now include `next-page-token` which if not set by the server, will be `null`, and included in the `toString` representation. ``` public String nextPageToken() { return nextPageToken; } @Override public String toString() { return MoreObjects.toStringHelper(this) .add("namespaces", namespaces()) .add("next-page-token", nextPageToken()) .toString(); } ``` Thus when running these `testRoundTripSerDe` tests they will fail, as they will have the `next-page-token` in them. ``` Expected :"{"identifiers":[{"namespace":["accounting","tax"],"name":"paid"}]}" Actual :"{"identifiers":[{"namespace":["accounting","tax"],"name":"paid"}],"next-page-token":null}" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org