amogh-jahagirdar commented on code in PR #602:
URL: https://github.com/apache/iceberg-python/pull/602#discussion_r1564265956
##########
tests/integration/test_inspect_table.py:
##########
@@ -266,3 +266,56 @@ def test_inspect_entries_partitioned(spark: SparkSession,
session_catalog: Catal
assert df.to_pydict()['data_file'][0]['partition'] == {'dt_day':
date(2021, 2, 1), 'dt_month': None}
assert df.to_pydict()['data_file'][1]['partition'] == {'dt_day': None,
'dt_month': 612}
+
+
+@pytest.mark.integration
+@pytest.mark.parametrize("format_version", [1, 2])
+def test_inspect_refs(
+ spark: SparkSession, session_catalog: Catalog, arrow_table_with_null:
pa.Table, format_version: int
+) -> None:
+ identifier = "default.table_metadata_refs"
+ tbl = _create_table(session_catalog, identifier,
properties={"format-version": format_version})
+
+ # write data to create snapshot
+ tbl.overwrite(arrow_table_with_null)
+
+ # create a test branch
+ spark.sql(
+ f"""
+ ALTER TABLE {identifier} CREATE BRANCH IF NOT EXISTS testBranch RETAIN 7
DAYS WITH SNAPSHOT RETENTION 2 SNAPSHOTS
+ """
+ )
+
+ # create a test tag against current snapshot
+ current_snapshot = tbl.current_snapshot()
+ assert current_snapshot is not None
+ current_snapshot_id = current_snapshot.snapshot_id
+
+ spark.sql(
+ f"""
+ ALTER TABLE {identifier} CREATE TAG testTag AS OF VERSION
{current_snapshot_id} RETAIN 180 DAYS
+ """
+ )
+
+ df = tbl.refresh().inspect.refs()
+
+ assert df.column_names == [
+ 'name',
+ 'type',
+ 'snapshot_id',
+ 'max_reference_age_in_ms',
+ 'min_snapshots_to_keep',
+ 'max_snapshot_age_in_ms',
+ ]
+
+ for snapshot_id in df['snapshot_id']:
+ assert isinstance(snapshot_id.as_py(), int)
Review Comment:
Nit: Why specifically only check the type for snapshot_id? If we want to
validate the types in the dataframe should we just check all of them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
