nastra commented on code in PR #10023:
URL: https://github.com/apache/iceberg/pull/10023#discussion_r1567311373
##########
api/src/main/java/org/apache/iceberg/util/CharSequenceWrapper.java:
##########
@@ -29,13 +29,16 @@ public static CharSequenceWrapper wrap(CharSequence seq) {
}
private CharSequence wrapped;
+ // lazily computed & cached hashCode
+ private transient int hashCode = 0;
Review Comment:
ah good point, thanks for finding that. Instead of making this an `Integer`
I actually introduced a boolean flag. The `String' implementation does the same
thing so that the hash isn't re-calculated when the hash is actually 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
