Fokko commented on code in PR #534:
URL: https://github.com/apache/iceberg-python/pull/534#discussion_r1571256522
##########
pyproject.toml:
##########
@@ -72,6 +72,10 @@ gcsfs = { version = ">=2023.1.0,<2024.1.0", optional = true }
psycopg2-binary = { version = ">=2.9.6", optional = true }
sqlalchemy = { version = "^2.0.18", optional = true }
getdaft = { version = ">=0.2.12", optional = true }
+botocore = "1.34.51"
+typing-extensions = "4.9.0"
+pydantic-core = "^2.16.3"
+numpy = "1.24"
Review Comment:
Do we want to make these dependencies required? You don't need botocore if
you're a GCP user. Also, numpy should be optional if you use s3fs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
