nastra commented on code in PR #10150: URL: https://github.com/apache/iceberg/pull/10150#discussion_r1575736834
########## core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java: ########## @@ -48,6 +48,10 @@ protected OverwriteFiles self() { @Override protected String operation() { + if (deletesDataFiles() && !addsDataFiles()) { + return DataOperations.DELETE; + } + Review Comment: makes sense, I've updated this in the second commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org