pvary commented on code in PR #10207:
URL: https://github.com/apache/iceberg/pull/10207#discussion_r1578858474
##########
flink/v1.19/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java:
##########
@@ -130,7 +131,9 @@ private ScanContext(
this.watermarkColumn = watermarkColumn;
this.watermarkColumnTimeUnit = watermarkColumnTimeUnit;
- validate();
+ if (!skipValidate) {
Review Comment:
The `TestStreamScanSql` was stuck because we set `snapshotId` too.
So this is for `snapshotId` and for `endSnapshotId`.
On the philosophical level, the question is:
- Do we want to make sure that the created `ScanContext` is always valid?
If yes, then we change the `copyWithAppendsBetween` and the `
copyWithSnapshotId` to remove the `streaming` flag, as those are not a
streaming scans anymore.
If no, then we accept that the programmatically creates `ScanContext`
objects don't need validation.
I opted for the first solution as I'm not sure where we depend on the
streaming settings, and it was the least disruptive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
