nastra commented on code in PR #9852:
URL: https://github.com/apache/iceberg/pull/9852#discussion_r1579292821
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -209,11 +262,58 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge) {
}
}
+ @Override
+ public boolean dropView(TableIdentifier identifier) {
+ if (!isValidIdentifier(identifier)) {
+ return false;
+ }
+
+ try {
+ String database = identifier.namespace().level(0);
+ String viewName = identifier.name();
+
+ HiveViewOperations ops = (HiveViewOperations) newViewOps(identifier);
+ ViewMetadata lastViewMetadata = null;
+ try {
+ lastViewMetadata = ops.current();
+ } catch (NotFoundException e) {
+ LOG.warn("Failed to load view metadata for view: {}", identifier, e);
+ }
+
+ clients.run(
+ client -> {
+ client.dropTable(database, viewName, false, false);
+ return null;
+ });
+
+ if (lastViewMetadata != null) {
+ CatalogUtil.dropViewMetadata(ops.io(), lastViewMetadata);
+ LOG.info("Dropped view: {}", identifier);
+ return true;
Review Comment:
I don't think this is correct to return `true` here. It should be in L295
(as you had it before)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
