bryanck commented on code in PR #10186:
URL: https://github.com/apache/iceberg/pull/10186#discussion_r1579467601
##########
kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/IcebergWriterFactoryTest.java:
##########
@@ -83,4 +90,26 @@ public void testAutoCreateTable(boolean partitioned) {
assertThat(specCaptor.getValue().isPartitioned()).isEqualTo(partitioned);
assertThat(propsCaptor.getValue()).containsKey("test-prop");
}
+
+ @Test
+ public void testNamespaceCreation() throws IOException {
+ TableIdentifier tableIdentifier =
+ TableIdentifier.of(Namespace.of("foo1", "foo2", "foo3"), "bar");
+ Schema schema = new Schema(Types.NestedField.required(1, "id",
Types.StringType.get()));
+
+ try (InMemoryCatalog catalog = new InMemoryCatalog()) {
Review Comment:
I'd prefer using the ArgumentCaptor approach, rather than relying on
InMemoryCatalog. This is consistent with the auto create test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
