rahil-c commented on code in PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#discussion_r1580469059
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTViewCatalog.java:
##########
@@ -144,6 +157,65 @@ public void closeCatalog() throws Exception {
}
}
+ @Test
+ public void testPaginationForListViews() {
+ RESTCatalogAdapter adapter = Mockito.spy(new
RESTCatalogAdapter(backendCatalog));
+ RESTCatalog catalog =
+ new RESTCatalog(SessionCatalog.SessionContext.createEmpty(), (config)
-> adapter);
+ catalog.initialize("test",
ImmutableMap.of(RESTSessionCatalog.REST_PAGE_SIZE, "10"));
+
+ int numberOfItems = 20;
+ int numberOfInvocations = 2;
+ String namespaceName = "newdb";
+ String viewName = "newview";
+
+ // create initial namespace
+ catalog().createNamespace(Namespace.of(namespaceName));
+
+ // create several views under namespace, based off a table for listing and
verify
+ for (int i = 0; i < numberOfItems; i++) {
+ TableIdentifier viewIndentifier = TableIdentifier.of(namespaceName,
viewName + i);
+ catalog
+ .buildView(viewIndentifier)
+ .withSchema(SCHEMA)
+ .withDefaultNamespace(viewIndentifier.namespace())
+ .withQuery("spark", "select * from ns.tbl")
+ .create();
+ }
+ List<TableIdentifier> views =
catalog.listViews(Namespace.of(namespaceName));
+ assertThat(views).hasSize(numberOfItems);
+
+ Mockito.verify(adapter)
+ .execute(
+ eq(HTTPMethod.GET),
+ eq("v1/config"),
+ any(),
+ any(),
+ eq(ConfigResponse.class),
+ any(),
+ any());
+
+ Mockito.verify(adapter, times(numberOfItems))
+ .execute(
+ eq(HTTPMethod.POST),
+ eq(String.format("v1/namespaces/%s/views", namespaceName)),
+ any(),
+ any(),
+ eq(LoadViewResponse.class),
+ any(),
+ any());
+
+ Mockito.verify(adapter, times(numberOfInvocations))
+ .execute(
+ eq(HTTPMethod.GET),
+ eq(String.format("v1/namespaces/%s/views", namespaceName)),
+ eq(ImmutableMap.of("pageToken", "10", "pageSize", "10")),
Review Comment:
@nastra I am able to make two separate requests with `.handleRequest`
instead of `execute`, and send the correct query params for each call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
