nastra commented on code in PR #9728: URL: https://github.com/apache/iceberg/pull/9728#discussion_r1582996766
########## core/src/main/java/org/apache/iceberg/SnapshotsTable.java: ########## @@ -27,7 +28,8 @@ * <p>This does not include snapshots that have been expired using {@link ExpireSnapshots}. */ public class SnapshotsTable extends BaseMetadataTable { - private static final Schema SNAPSHOT_SCHEMA = + @VisibleForTesting + static final Schema SNAPSHOT_SCHEMA = Review Comment: I think having a custom schema for the test makes sense here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org