nastra commented on code in PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#discussion_r1584309569
##########
data/src/test/java/org/apache/iceberg/data/TestLocalScan.java:
##########
@@ -281,36 +271,34 @@ public void testFullScan() {
expected.addAll(file3FirstSnapshotRecords);
Set<Record> records = Sets.newHashSet(results);
- Assert.assertEquals(
- "Should produce correct number of records", expected.size(),
records.size());
- Assert.assertEquals("Random record set should match",
Sets.newHashSet(expected), records);
+ Assertions.assertThat(records).as("Should produce correct number of
records")
+ .hasSameSizeAs(expected);
+ Assertions.assertThat(records).as("Random record set should match")
+ .hasSameSizeAs(expected);
}
- @Test
+ @TestTemplate
public void testFilter() {
Iterable<Record> result =
IcebergGenerics.read(sharedTable).where(lessThan("id", 3)).build();
- Assert.assertEquals(
- "Records should match file 1",
- Sets.newHashSet(file1FirstSnapshotRecords),
- Sets.newHashSet(result));
-
+ Assertions.assertThat(Sets.newHashSet(file1FirstSnapshotRecords))
+ .isEqualTo(Sets.newHashSet(result))
+ .as("Records should match file 1");
Review Comment:
same comment regarding the ordering of `.as()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
