pvary commented on code in PR #10200: URL: https://github.com/apache/iceberg/pull/10200#discussion_r1584738269
########## core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java: ########## @@ -109,18 +112,34 @@ protected abstract class BaseEqualityDeltaWriter implements Closeable { private final StructProjection structProjection; private RollingFileWriter dataWriter; private RollingEqDeleteWriter eqDeleteWriter; - private SortedPosDeleteWriter<T> posDeleteWriter; + private FileWriter<PositionDelete<T>, DeleteWriteResult> posDeleteWriter; private Map<StructLike, PathOffset> insertedRowMap; protected BaseEqualityDeltaWriter(StructLike partition, Schema schema, Schema deleteSchema) { + this(partition, schema, deleteSchema, DeleteGranularity.PARTITION); + } + + protected BaseEqualityDeltaWriter( + StructLike partition, + Schema schema, + Schema deleteSchema, + DeleteGranularity deleteGranularity) { Review Comment: I love this 😄 The PR is sooo much smaller! @stevenzwu: one final round of review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org