HonahX commented on code in PR #704:
URL: https://github.com/apache/iceberg-python/pull/704#discussion_r1591786106
##########
tests/integration/test_writes/test_writes.py:
##########
@@ -833,3 +833,13 @@ def test_sanitize_character_partitioned(catalog: Catalog)
-> None:
)
assert len(tbl.scan().to_arrow()) == 22
+
+
[email protected]("format_version", [1, 2])
+def table_write_subset_of_schema(session_catalog: Catalog,
arrow_table_with_null: pa.Table, format_version: int) -> None:
+ identifier = "default.table_append_subset_of_schema"
+ tbl = _create_table(session_catalog, identifier, {"format-version":
format_version}, [arrow_table_with_null])
+ arrow_table_without_some_columns =
arrow_table_with_null.combine_chunks().drop(arrow_table_with_null.column_names[0])
+ assert len(arrow_table_without_some_columns.columns) <
len(arrow_table_with_null.columns)
+ tbl.overwrite(arrow_table_without_some_columns)
+ tbl.append(arrow_table_without_some_columns)
Review Comment:
The test looks good. Just have one request: Shall we check the content of
final table after `overwrite` and `append`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
