syun64 commented on code in PR #703:
URL: https://github.com/apache/iceberg-python/pull/703#discussion_r1592430523
##########
pyiceberg/transforms.py:
##########
@@ -349,6 +356,13 @@ def dedup_name(self) -> str:
def preserves_order(self) -> bool:
return True
+ @abstractmethod
+ def pyarrow_transform(self, source: IcebergType) -> "Callable[[pa.Array],
pa.Array]": ...
Review Comment:
Sounds good :)
##########
Makefile:
##########
@@ -43,7 +43,7 @@ test-integration:
sleep 10
docker compose -f dev/docker-compose-integration.yml cp
./dev/provision.py spark-iceberg:/opt/spark/provision.py
docker compose -f dev/docker-compose-integration.yml exec -T
spark-iceberg ipython ./provision.py
- poetry run pytest tests/ -v -m integration ${PYTEST_ARGS}
+ poetry run pytest
tests/integration/test_writes/test_partitioned_writes.py -v -m integration
${PYTEST_ARGS}
Review Comment:
Of course :) Thank you for flagging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
