rdblue commented on a change in pull request #1197:
URL: https://github.com/apache/iceberg/pull/1197#discussion_r455330224
##########
File path: orc/src/main/java/org/apache/iceberg/orc/OrcFileAppender.java
##########
@@ -51,12 +51,12 @@
private final OutputFile file;
private final Writer writer;
private final VectorizedRowBatch batch;
- private final OrcValueWriter<D> valueWriter;
+ private final OrcRowWriter<D> valueWriter;
Review comment:
What is the purpose of changing `OrcValueWriter` to `OrcRowWriter`? It
seems like this isn't really necessary for the purpose of this commit and
causes quite a few changes. Is there value in doing this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
