shardulm94 commented on a change in pull request #1207:
URL: https://github.com/apache/iceberg/pull/1207#discussion_r455401422
##########
File path: orc/src/main/java/org/apache/iceberg/orc/OrcRowReader.java
##########
@@ -29,6 +29,6 @@
/**
* Reads a row.
*/
- T read(VectorizedRowBatch batch, int row);
+ T read(VectorizedRowBatch batch, long batchOffsetInFile, int
rowOffsetInBatch);
Review comment:
Thanks for the suggestion! This reduces the code changes significantly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
