amogh-jahagirdar commented on code in PR #10337:
URL: https://github.com/apache/iceberg/pull/10337#discussion_r1601983226
##########
core/src/main/java/org/apache/iceberg/ClientPoolImpl.java:
##########
@@ -70,37 +71,29 @@ public <R> R run(Action<R, C, E> action, boolean retry)
throws E, InterruptedExc
try {
return action.run(client);
} catch (Exception exc) {
- if (!retry || !isConnectionException(exc)) {
- throw exc;
+ if (retry && isConnectionException(exc)) {
Review Comment:
I'm good with the implementation, I also actually find it a bit more
readable when expressed as `if (retry && isConnectionException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
