adutra commented on code in PR #10345:
URL: https://github.com/apache/iceberg/pull/10345#discussion_r1605267440
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -915,7 +923,13 @@ private FileIO tableFileIO(SessionContext context,
Map<String, String> config) {
}
private AuthSession tableSession(Map<String, String> tableConf, AuthSession
parent) {
- Pair<String, Supplier<AuthSession>> newSession = newSession(tableConf,
tableConf, parent);
+ Map<String, String> credentials =
Maps.newHashMapWithExpectedSize(tableConf.size());
Review Comment:
Note: this change still allows overriding `credential` from the
`SessionContext` which I believe is the desired behavior. But I'm happy to also
apply the restriction to `SessionContext` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
